Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch: added missing MIPS HI/LO register defs #749

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Tazdevil971
Copy link
Contributor

As per title, this pull request adds missing HI/LO register definitions, those registers are used in older MIPS CPU (pre R6).

Register DWARF numbers come directly from LLVM

Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the MIPS register definitions have a $ prefix. I assume these should too.

@Tazdevil971
Copy link
Contributor Author

Thanks for the speedy reply! I updated the patch to now include the $ prefix. My original thought was that since the HI/LO registers are special, and cannot be referenced or named directly in assembly (they can only be accessed though special mflo/mfhi/mtlo/mthi instructions), it would have been better to separate them from the rest.

But looking at other registers definitions no one does that, also I agree that it looks better like this.

Copy link
Collaborator

@philipc philipc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philipc philipc merged commit 4981be0 into gimli-rs:master Sep 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants