Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tab title rename logic #35

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Lemonbrush
Copy link

I added tab title rename logic
It allows you to rename tabs without affecting tab node paths as it is now
To be honest, this solution looks bad. If you have an advice on haw to improve it I would be happy to make an update but now it is something at least

@gilzoide
Copy link
Owner

gilzoide commented Aug 11, 2024

Hey @Lemonbrush, thanks for the contribution!
Renaming tabs is a very nice addition, much needed if you ask me.

If you have an advice on haw to improve it I would be happy to make an update but now it is something at least

I think tab naming should be kept in the DockableLayout resource instead of the DockableContainer. This way it would be easily editable without any code and would get properly serialized.

Not sure if it makes more sense to put this in the DockableLayout itself, like hidden_tabs is, or if it makes sense to put this in the DockableLayoutPanel. I guess the first option is better, because one could rearrange the panels several times and the name mapping would be kept in the same place, much simpler.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants