-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ggml: fix vulkan-shaders-gen build #10448
base: master
Are you sure you want to change the base?
Conversation
@jeffbolznv , @0cc4m |
@sparkleholic @jeffbolznv I understand, I'm sorry that a few PRs are getting delayed because of me. I'm currently ill, but getting better and I should be able to catch up with all of them later this week. Maybe you can resolve the merge conflict already? |
No rush, get well! I'm not an expert at cmake or cross compilation, so I don't think I should review the change. |
The vulkan-shaders-gen target was not being built correctly in case of cross-compilation. Other outputs need to be built for the cross compile target, but vulkan-shaders-gen needs to be built for the host.
e9b3777
to
bf43351
Compare
@0cc4m |
I can confirm this still works as usual on my system, but I'm also not a CMake expert. Maybe @bandoti can take a look? |
I am happy to take a look. The one thing that comes to mind here after initial look through is being able to customize the compiler in this case. In particular, It would be worthwhile to add a default toolchain file for the build and allow one to customize by passing This would allow one to use a desire toolchain—maybe clang, etc. And a lot of those switches passed to ExternalProject_Add() can of course be moved to the toolchain file instead. |
- Add GGML_SHADERS_GEN_TOOLCHAIN CMake option. - Auto-detect host toolchain if not set.
@bandoti I have updated the code to handle the Please review the updated code once again. |
The vulkan-shaders-gen target was not being built correctly in case of cross-compilation.
Other outputs need to be built for the cross compile target, but vulkan-shaders-gen needs to be built for the host.