Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server: handle generation until context is filled #10128

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Server: handle generation until context is filled #10128

wants to merge 2 commits into from
+38 −2

Conversation

VJHack
Copy link
Contributor

@VJHack VJHack commented Nov 1, 2024

This PR fixes bug #9933. When n_predict is set to -2, generation will occur until the context is filled. Some basic server tests were added to demonstrate functionality.

@github-actions github-actions bot added examples python python script changes server labels Nov 1, 2024
@VJHack VJHack changed the title Server: generate until context is filled Server: handle generation until context is filled Nov 1, 2024
@VJHack VJHack mentioned this pull request Nov 1, 2024
Open
4 tasks
ngxson
ngxson reviewed Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to discourage new people to make contributions to the project. But to be honest, coding style in this PR does not even meet the minimum requirement of this project. You should probably take more time to read the code.

examples/server/server.cpp Outdated Show resolved Hide resolved
examples/server/server.cpp Outdated Show resolved Hide resolved
examples/server/tests/features/n_predict.feature Show resolved Hide resolved
examples/server/tests/features/steps/steps.py Outdated Show resolved Hide resolved
@VJHack
Copy link
Contributor Author

VJHack commented Nov 23, 2024

I don't want to discourage new people to make contributions to the project. But to be honest, coding style in this PR does not even meet the minimum requirement of this project. You should probably take more time to read the code.

I appreciate you taking the time to review my work. I'm new to this project and am still working on my coding style. Your feedback definitely helped a lot. I'll be more careful in my future contributions. Thank you!

@VJHack VJHack requested a review from ngxson November 23, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngxson ngxson Awaiting requested review from ngxson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
examples python python script changes server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VJHack @ngxson @kylo5aby