Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cBioPortal page #83

Merged
merged 6 commits into from
May 2, 2024
Merged

Add cBioPortal page #83

merged 6 commits into from
May 2, 2024

Conversation

anngvu
Copy link
Contributor

@anngvu anngvu commented Mar 19, 2024

See preview here 👉🏼 https://docs-git-feat-cbioportal-page-gf-dcc-service.vercel.app/docs/workflows/cBioPortal

@cconrad8 -- You can make any changes before adding Ino and Ritika to review. I prompted ChatGPT to simplify and create the rough diagram from original version, so there things to double-check. Restyling colors fine.

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 7:55pm

@anngvu anngvu changed the title Feat/c bio portal page Add cBioPortal page Mar 19, 2024
@anngvu anngvu requested a review from cconrad8 March 19, 2024 15:34
@anngvu anngvu linked an issue Mar 19, 2024 that may be closed by this pull request
Copy link
Contributor

@cconrad8 cconrad8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! I changed the colors and made some text edits. otherwise I think good to me!

@ritikakundra
Copy link

Looks good to me. Quick question, for, " Is direct data contribution to cBioPortal feasible by the contributor?- Yes", not sure why we need "CONTRIBUTOR: Works directly with MSKCC on the submission process of data to cBioPortal".

Maybe not for the workflow, but we should figure out how you will hand over the files to us. For Drapkin cohort, if I remember correctly, it was via synapse. Should we continue with that process? Datahub will not be an option as data is not public till phase 3

@cconrad8
Copy link
Contributor

cconrad8 commented Apr 4, 2024

Looks good to me. Quick question, for, " Is direct data contribution to cBioPortal feasible by the contributor?- Yes", not sure why we need "CONTRIBUTOR: Works directly with MSKCC on the submission process of data to cBioPortal".

@anngvu @ritikakundra

I think we are trying to say - "is the contributor savy enough to work on preparing the necessary files for cbioportal or does Sage need to step in to do this ? Correct?

Perhaps rephrasing is needed:

"Does the contributor have the expertise and resources to independently manage and prepare data submissions for cBioPortal, or is intervention from Sage required to facilitate this process?

@cconrad8
Copy link
Contributor

cconrad8 commented Apr 4, 2024

Following our discussion today: We want to better streamline this process and let's try to simplify the workflow so it doesn't have as many exchanges between the contributor, MSK, and Sage.

  • Sage will prepare the files to be submitted and discuss internally on how we can use existing DCC (Genie and HTAN) protocols to prep files

@anngvu
Copy link
Contributor Author

anngvu commented May 2, 2024

@ritikakundra @inodb @cconrad8

I simplified this a bit so MSKCC does even less (no path to work directly with contribs). Merging this version, make a PR or issue if we need to revisit later.

@anngvu anngvu merged commit bff341e into main May 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SOP for cBioPortal integration/submission
3 participants