Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ale/gey 3836 redesign the profile section based on designs #1129

Merged

Conversation

verbiricha
Copy link
Contributor

@verbiricha verbiricha commented Aug 30, 2023

  • Update nostr icon
  • Adjust connect button size and support secondary variant
  • Update external account component to avoid low contrast in dark mode

@linear
Copy link

linear bot commented Aug 30, 2023

GEY-3836 Redesign the Profile section based on designs

Issue

Solution

  • Update Nostr icon style in profile

  • Update the 'Connect your accounts' button to be simple secondary button below the connected accounts. If a user clicks that button he will get the pop up which will allow him to choose which account to connect.

    Note: User can only login once with Nostr and Twitter, but 7 times with lightning (lnurl-auth).

    Component 445 - Product designs (Figma)

Figma:

User Profile Page - Contributions - Product designs (Figma)

@verbiricha verbiricha marked this pull request as ready for review August 31, 2023 08:58
src/pages/auth/ConnectWithLightning.tsx Outdated Show resolved Hide resolved
src/pages/auth/ConnectWithLightning.tsx Show resolved Hide resolved
src/pages/auth/ConnectWithNostr.tsx Outdated Show resolved Hide resolved
@sajald77
Copy link
Collaborator

sajald77 commented Sep 1, 2023

Looking good @verbiricha, I have a few concerns I mentioned in the review, apart from that looks solid!

@verbiricha verbiricha merged commit 6cdbc20 into staging Sep 4, 2023
1 check passed
@verbiricha verbiricha deleted the ale/gey-3836-redesign-the-profile-section-based-on-designs branch September 4, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants