Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pisi/eopkg: Sync with deterministic upstream versions #2964

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

ermo
Copy link
Contributor

@ermo ermo commented Jun 13, 2024

Summary

Constitutes phase 2 of #2193

eopkg

  • Remove eopkg4-bin symlink. Use eopkg.bin instead.
  • eopkg.bin and eopkg.py3 will now deterministically install baselayout and eopkg packages before anything else.
  • Add eopkg to system.base in preparation for epoch bump process.
  • Add mirrors.conf and sandbox.conf files in preparation for epoch bump process ownership changes between pisi(py2) and eopkg(py3) packages.

pisi

  • Sync with pisi v3.12 upstream release, which always installs baselayout eopkg first if they are present in any given install/upgrade order.
  • Add rundep on python2-ordered-set package
  • Make pisi co-installable with the eopkg(py3) package
  • Miscellaneous shebang and file name extension changes
  • Sort pspec.xml file sections lexically for ease of reading/tweaking
  • Change long_description to indicate that pisi is now considered legacy
  • Create new comar/manager.py3 and comar/package.py3 build scripts in preparation for enabling building pisi with eopkg.py3 build.
    Thank you to @ultr4_l4s3r for the porting work. The current comar/*.py scripts are still python2 for now.

ypkg
(no changes necessary)

solus-sc
(no changes necessary)

Test Plan

  1. build + install eopkg&python-eopkg, and add them to my local repo (as a separate step).
  2. build + install pisi, and add it to the local repo (as a separate step).
  3. test that solus-sc still works. (as the final step).

Checklist

  • Package was built and tested against unstable

@ermo ermo marked this pull request as draft June 13, 2024 14:40
@ermo ermo force-pushed the eopkg-pisi-ypkg-solusSC-update branch 4 times, most recently from 5188726 to d734f4b Compare June 17, 2024 20:50
@ermo
Copy link
Contributor Author

ermo commented Jun 17, 2024

Just to give an idea how each package is changing (when installed side-by-side) compared to the previous versions:

--- eopkg-6.txt 2024-06-17 23:01:10.772002005 +0200
+++ eopkg-7.txt 2024-06-24 02:18:11.919587130 +0200
@@ -1,3 +1,2 @@
 /usr/bin/eopkg.bin
-/usr/bin/eopkg4-bin
 /usr/share/PackageKit/helpers/eopkg/eopkgBackend.bin

--- pisi-111.txt        2024-06-24 00:18:51.121537384 +0200
+++ pisi-112.txt        2024-06-24 02:14:12.400067008 +0200
@@ -1,12 +1,15 @@
 /etc/mudur/locale
-/usr/bin/check-newconfigs.py
+/usr/bin/check-newconfigs.py2
 /usr/bin/eopkg
 /usr/bin/eopkg-cli
+/usr/bin/eopkg.py2
 /usr/bin/lseopkg
-/usr/bin/lspisi
-/usr/bin/revdep-rebuild
+/usr/bin/lseopkg.py2
+/usr/bin/lspisi.py2
+/usr/bin/revdep-rebuild.sh
 /usr/bin/uneopkg
-/usr/bin/unpisi
+/usr/bin/uneopkg.py2
+/usr/bin/unpisi.py2
 /usr/lib/python2.7/site-packages/pisi-3.11-py2.7.egg-info
 /usr/lib/python2.7/site-packages/pisi/__init__.py
 /usr/lib/python2.7/site-packages/pisi/actionsapi/__init__.py

@ermo ermo added Topic: Plumbing Core components Topic: Tooling Tools and scripts labels Jun 17, 2024
@ermo ermo added this to the Solus 4.6 milestone Jun 17, 2024
ermo added a commit to getsolus/solbuild that referenced this pull request Jun 18, 2024
This ensures that solbuild will work with the phase1+2 changes to eopkg
and pisi packages [here](getsolus/packages#2964)

In addition, make a cosmetic tweak to eopkg install commands (which will
effectively be using eopkg.bin when the PR above lands) so the -y flag
is set before the -c flag when installing components.

Signed-off-by: Rune Morling <[email protected]>
@ermo ermo force-pushed the eopkg-pisi-ypkg-solusSC-update branch 4 times, most recently from 561d8f1 to afc910e Compare June 23, 2024 22:47
@ermo ermo changed the title pisi: Drop files that eopkg4 should be handling pisi/eopkg: Sync with deterministic upstream versions Jun 23, 2024
@ermo ermo force-pushed the eopkg-pisi-ypkg-solusSC-update branch 2 times, most recently from 5a9b085 to 43a7126 Compare June 24, 2024 00:14
@ermo ermo marked this pull request as ready for review June 24, 2024 00:19
@ermo ermo force-pushed the eopkg-pisi-ypkg-solusSC-update branch from 43a7126 to 33f09f5 Compare June 24, 2024 00:24
ermo added 2 commits June 24, 2024 11:55
**Summary**
- Remove eopkg4-bin symlink. Use eopkg.bin instead.
- eopkg.bin and eopkg.py3 will now deterministically install baselayout
  and eopkg packages before anything else.
- Add eopkg to system.base in preparation for epoch bump process.
- Add mirrors.conf and sandbox.conf files in preparation for epoch bump
  process ownership changes between pisi(py2) and eopkg(py3) packages.

Signed-off-by: Rune Morling <[email protected]>
**Summary**
- Sync with pisi v3.12.1 upstream release, which always installs baselayout
  eopkg first if they are present in any given install/upgrade order.
- Add rundep on python2-ordered-set package
- Make pisi co-installable with the eopkg(py3) package
- Miscellaneous shebang and file name extension changes
- Sort pspec.xml file sections lexically for ease of reading/tweaking
- Change long_description to indicate that pisi is now considered legacy
- Create new comar/manager.py3 and comar/package.py3 build scripts in
  preparation for enabling building pisi with `eopkg.py3 build`.
  Thank you to @ultr4_l4s3r for the porting work.
  The current comar/*.py scripts are still python2 for now.

Signed-off-by: Rune Morling <[email protected]>
@ermo ermo force-pushed the eopkg-pisi-ypkg-solusSC-update branch from 33f09f5 to 02f1d61 Compare June 24, 2024 10:00
Copy link
Member

@sheepman4267 sheepman4267 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works per the test plan!

@ermo ermo merged commit f5b5bae into main Jun 24, 2024
1 check passed
@ermo ermo deleted the eopkg-pisi-ypkg-solusSC-update branch June 24, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: Plumbing Core components Topic: Tooling Tools and scripts
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants