Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Order of options in aggregate mode #81469

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zylphrex
Copy link
Member

Temporary fix to synchronize them. The real fix here is to not have useSorts take fields as as argument and be able to directly access fields.

Temporary fix to synchronize them. The real fix here is to not have `useSorts`
take fields as as argument and be able to directly access fields.
@Zylphrex Zylphrex requested a review from a team as a code owner November 29, 2024 19:40
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tatic/app/views/explore/tables/aggregatesTable.tsx 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81469      +/-   ##
==========================================
- Coverage   80.37%   80.37%   -0.01%     
==========================================
  Files        7228     7228              
  Lines      319540   319550      +10     
  Branches    20770    20772       +2     
==========================================
- Hits       256833   256831       -2     
- Misses      62304    62316      +12     
  Partials      403      403              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant