feat(widget-builder): Widget builder slideout #81444
Conversation
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #81444 +/- ##
==========================================
- Coverage 80.37% 80.36% -0.01%
==========================================
Files 7226 7228 +2
Lines 319469 319530 +61
Branches 20762 20769 +7
==========================================
+ Hits 256775 256804 +29
- Misses 62304 62323 +19
- Partials 390 403 +13 |
|
|
||
| export default WidgetBuilderSlideout; | ||
|
|
||
| function WidgetBuilderSlideout({isOpen, onClose}: WidgetBuilderSlideoutProps) { |
There was a problem hiding this comment.
Can we rename this file to widgetBuilderSlideout.tsx? The new isn't really necessary
| &:hover { | ||
| color: ${p => p.theme.gray400}; | ||
| } | ||
| z-index: 100; |
There was a problem hiding this comment.
I was able to take this out and it worked fine, is it necessary?
There was a problem hiding this comment.
whoops no not really. This was a copy-paste mistake lolz
| const SlideoutHeaderWrapper = styled('div')` | ||
| padding: ${space(4)}; | ||
| display: flex; | ||
| justify-content: space-between; |
There was a problem hiding this comment.
If you lower the padding, add align-items: center, and a bottom border, and remove the margin from the SlideoutTitle, I think it ends up a bit closer to what the mockup is
There was a problem hiding this comment.
Ah yes I've already added this in my code for my next PR so it will be in there 👍
Bundle ReportChanges will increase total bundle size by 13.61kB (0.04%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Just the bare bones of the widget builder UI. This adds the slide-out functionality and a placeholder widget. You can see it on any dashboard page with the url parameter `devBuilderUI=true`. It looks like this so far: 
Just the bare bones of the widget builder UI. This adds the slide-out functionality and a placeholder widget. You can see it on any dashboard page with the url parameter
devBuilderUI=true. It looks like this so far: