Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support HTTP_METHOD and HTTP_REQUEST_METHOD for Otel Spans #3930

Open
wants to merge 3 commits into
base: 8.x.x
Choose a base branch
from

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Nov 26, 2024

📜 Description

Support both HttpAttributes.HTTP_REQUEST_METHOD and SemanticAttributes.HTTP_METHOD as source for httpMethod.

💡 Motivation and Context

Fixes double check for HttpAttributes.HTTP_REQUEST_METHOD and adds SemanticAttributes.HTTP_METHOD.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 26, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8a1a505

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 458.41 ms 515.39 ms 56.97 ms
Size 1.65 MiB 2.31 MiB 676.03 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant