Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Gradle 8.9, AGP 8.6.0, Kotlin 1.9.22 #3839

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

markushi
Copy link
Member

@markushi markushi commented Nov 1, 2024

📜 Description

androidx.benchmark requires a newer version of AGP for micro benchmarks. Bumping all required deps as well.

💡 Motivation and Context.

New features and faster builds.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

#skip-changelog

val kotlinStdLib = "stdlib-jdk8"

val springBootVersion = "2.7.5"
val springBoot3Version = "3.3.2"
val kotlinCompatibleLanguageVersion = "1.4"
val kotlinCompatibleLanguageVersion = "1.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this deserves a "Breaking changes" note at least? doubt anyone is still on this version, but gotta call it out (or make it part of v8?)

build.gradle.kts Outdated Show resolved Hide resolved
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of comments, but LGTM otherwise! I also assume that artifacts publishing works correctly after bumping the maven-publish plugin, I recall we had problems in the past

@markushi markushi enabled auto-merge (squash) November 6, 2024 21:21
@markushi
Copy link
Member Author

markushi commented Nov 7, 2024

a couple of comments, but LGTM otherwise! I also assume that artifacts publishing works correctly after bumping the maven-publish plugin, I recall we had problems in the past

Yeah I tried local publishing and compared some files side-by-side. Looking good! One difference I've seen: The .module files now link javadoc and sources, which they didn't before.

@romtsn
Copy link
Member

romtsn commented Nov 7, 2024

The .module files now link javadoc and sources, which they didn't before.

Oh that's nice, it probably fixes this issue? #3785

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 398.40 ms 415.83 ms 17.43 ms
Size 1.64 MiB 2.25 MiB 629.63 KiB

Previous results on branch: chore/gradle-agp-kotlin-version-bump

Startup times

Revision Plain With Sentry Diff
6af4c51 446.67 ms 465.26 ms 18.58 ms

App size

Revision Plain With Sentry Diff
6af4c51 1.64 MiB 2.25 MiB 629.59 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants