Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apollo3 GraphQL sample to Android sample app #2889

Closed
wants to merge 1 commit into from

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented Aug 7, 2023

📜 Description

...

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Add Apollo3 GraphQL sample to Android sample app ([#2889](https://github.com/getsentry/sentry-java/pull/2889))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 6215c6d

@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 316.14 ms 356.12 ms 39.98 ms
Size 1.72 MiB 2.29 MiB 575.74 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4bf202b 364.28 ms 419.66 ms 55.38 ms
3baa73f 267.45 ms 388.30 ms 120.85 ms
f274c79 334.86 ms 348.54 ms 13.68 ms
496bdfd 272.86 ms 407.33 ms 134.48 ms
fe10f05 314.71 ms 360.62 ms 45.90 ms
caf50ec 302.36 ms 325.25 ms 22.89 ms
87b3774 310.48 ms 362.04 ms 51.56 ms
fb296f0 340.61 ms 394.88 ms 54.27 ms
f60279b 324.60 ms 345.33 ms 20.73 ms
8820c5c 330.60 ms 416.86 ms 86.26 ms

App size

Revision Plain With Sentry Diff
4bf202b 1.72 MiB 2.29 MiB 575.54 KiB
3baa73f 1.72 MiB 2.29 MiB 575.52 KiB
f274c79 1.72 MiB 2.29 MiB 575.01 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
fe10f05 1.72 MiB 2.29 MiB 575.54 KiB
caf50ec 1.72 MiB 2.29 MiB 575.24 KiB
87b3774 1.72 MiB 2.29 MiB 575.54 KiB
fb296f0 1.72 MiB 2.29 MiB 575.70 KiB
f60279b 1.72 MiB 2.29 MiB 575.23 KiB
8820c5c 1.72 MiB 2.28 MiB 571.82 KiB

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (549cbb4) 80.52% compared to head (6215c6d) 80.52%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2889   +/-   ##
=========================================
  Coverage     80.52%   80.52%           
  Complexity     4714     4714           
=========================================
  Files           371      371           
  Lines         17566    17566           
  Branches       2365     2365           
=========================================
  Hits          14145    14145           
  Misses         2447     2447           
  Partials        974      974           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getsantry
Copy link

getsantry bot commented Oct 18, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 18, 2023
@adinauer adinauer closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant