Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov reports for Android modules #2868

Merged
merged 65 commits into from
Aug 10, 2023
Merged

Codecov reports for Android modules #2868

merged 65 commits into from
Aug 10, 2023

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Jul 27, 2023

Ref: #1454

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 323.88 ms 365.02 ms 41.14 ms
Size 1.72 MiB 2.29 MiB 575.74 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4bf202b 364.28 ms 419.66 ms 55.38 ms
3baa73f 267.45 ms 388.30 ms 120.85 ms
f274c79 334.86 ms 348.54 ms 13.68 ms
496bdfd 272.86 ms 407.33 ms 134.48 ms
fe10f05 314.71 ms 360.62 ms 45.90 ms
caf50ec 302.36 ms 325.25 ms 22.89 ms
87b3774 310.48 ms 362.04 ms 51.56 ms
fb296f0 340.61 ms 394.88 ms 54.27 ms
f60279b 324.60 ms 345.33 ms 20.73 ms
8820c5c 330.60 ms 416.86 ms 86.26 ms

App size

Revision Plain With Sentry Diff
4bf202b 1.72 MiB 2.29 MiB 575.54 KiB
3baa73f 1.72 MiB 2.29 MiB 575.52 KiB
f274c79 1.72 MiB 2.29 MiB 575.01 KiB
496bdfd 1.72 MiB 2.28 MiB 571.82 KiB
fe10f05 1.72 MiB 2.29 MiB 575.54 KiB
caf50ec 1.72 MiB 2.29 MiB 575.24 KiB
87b3774 1.72 MiB 2.29 MiB 575.54 KiB
fb296f0 1.72 MiB 2.29 MiB 575.70 KiB
f60279b 1.72 MiB 2.29 MiB 575.23 KiB
8820c5c 1.72 MiB 2.28 MiB 571.82 KiB

Previous results on branch: chore/codecov-android

Startup times

Revision Plain With Sentry Diff
017de29 318.20 ms 369.22 ms 51.02 ms
4efa490 291.47 ms 340.91 ms 49.44 ms
eeb6bde 298.45 ms 343.84 ms 45.39 ms
6f86503 304.67 ms 387.80 ms 83.12 ms
dea1453 320.00 ms 370.61 ms 50.61 ms
442eb35 301.83 ms 357.40 ms 55.58 ms
a151715 316.40 ms 369.94 ms 53.53 ms
8c00cca 314.42 ms 361.32 ms 46.90 ms
ba858b8 309.18 ms 357.28 ms 48.10 ms
b58b3b4 309.75 ms 374.51 ms 64.76 ms

App size

Revision Plain With Sentry Diff
017de29 1.72 MiB 2.29 MiB 575.74 KiB
4efa490 1.72 MiB 2.29 MiB 575.54 KiB
eeb6bde 1.72 MiB 2.29 MiB 575.54 KiB
6f86503 1.72 MiB 2.29 MiB 575.74 KiB
dea1453 1.72 MiB 2.29 MiB 575.74 KiB
442eb35 1.72 MiB 2.29 MiB 575.54 KiB
a151715 1.72 MiB 2.29 MiB 575.74 KiB
8c00cca 1.72 MiB 2.29 MiB 575.74 KiB
ba858b8 1.72 MiB 2.29 MiB 575.54 KiB
b58b3b4 1.72 MiB 2.29 MiB 575.74 KiB

@buenaflor buenaflor marked this pull request as ready for review July 27, 2023 15:30
@buenaflor buenaflor marked this pull request as draft July 27, 2023 15:30
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.80% ⚠️

Comparison is base (f60cce2) 81.38% compared to head (60c5497) 79.59%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2868      +/-   ##
============================================
- Coverage     81.38%   79.59%   -1.80%     
- Complexity     4645     6005    +1360     
============================================
  Files           354      468     +114     
  Lines         17114    23182    +6068     
  Branches       2313     3149     +836     
============================================
+ Hits          13928    18451    +4523     
- Misses         2236     3345    +1109     
- Partials        950     1386     +436     

see 160 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romtsn
Copy link
Member

romtsn commented Aug 8, 2023

sentry-compose is missing again though, probably because the plugin is not aware of androidMain? We could merge this one and follow up with another PR if you will
image

@romtsn
Copy link
Member

romtsn commented Aug 8, 2023

We might need to look into https://kotlin.github.io/kotlinx-kover/gradle-plugin/ for KMP modules

@buenaflor buenaflor requested a review from romtsn August 9, 2023 13:20
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@buenaflor buenaflor merged commit d55d97a into main Aug 10, 2023
19 of 20 checks passed
@buenaflor buenaflor deleted the chore/codecov-android branch August 10, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants