Fix for Capacitor 5/Angular 16 peer dependencies error

[ahunter135]

No description provided.

[afilp]

@lucas-zimerman Can you please review and merge this? As we need to do an npm install and without this change it fails.

Thanks a lot!

[lucas-zimerman]

In this case wouldn't it break for uses using the non ivy version of Angular?

[ahunter135]

@lucas-zimerman

It might. I'm new to this. But we also need to do an install and it fails without this.

Side effect of this change: I'm on capacitor angular, but I can't import it from there. I have to import from sentry/angular-ivy. So there could be more to do here.

I just wanted to start the discussion back up because at this point, sentry is not supporting capacitor 5 and angular 16.

[emelampianakis]

angular 16 needs the ivy distribution. if this is the case maby you can remove the dependency completely so each dev can install the package needed.
Sentry suggests ivy for angular 11+

[ahunter135]

So instead of putting ivy in, just remove it entirely? I can do that. @emelampianakis

[emelampianakis]

So instead of putting ivy in, just remove it entirely? I can do that. @emelampianakis

Yeah, I think this is the correct approach, but then the Installation part of the readme should also be updated.
Maby like this from https://docs.sentry.io/platforms/javascript/guides/angular/?original_referrer=https%3A%2F%2Fwww.google.com%2F

#Angular 12 and newer:
npm install --save @sentry/capacitor @sentry/angular-ivy

#Angular 10 and 11:
npm install --save @sentry/capacitor @sentry/angular

@lucas-zimerman you think this would be ok?

[emelampianakis]

Hello @ahunter135 can you try the changes I mentioned above?
Just remove both @sentry/angular & @sentry/angular-ivy dependencies and update the readme file.
We really need this fix cause as it is right now angular 16 projects cant use this package.

[ahunter135]

@emelampianakis made the requested changes!

[afilp]

@lucas-zimerman Can you please approve and merge the changes so that we can start using the fix soon (with Angular 16)? Thanks a lot!

[krystofwoldrich]

Based on #405 (comment) the peer deps are not the issue.

Thank you, everyone, for the comments, please use @sentry/angular-ivy with Angular 12 and newer.

Follow up PR with readme update from this PR -> #469