Fix: Query results in public dashboard not loading when query ends with semicolon #6351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #6351 +/- ##
==========================================
- Coverage 60.73% 60.73% -0.01%
==========================================
Files 153 153
Lines 12514 12513 -1
Branches 1695 1695
==========================================
- Hits 7601 7600 -1
Misses 4687 4687
Partials 226 226
|
justinclift
approved these changes
Aug 6, 2023
|
@manikBS Just sent you a GitHub invite to the project as well, so you have access to make changes in the project that seem useful. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This PR fixes the formatting flake8 error resulting in the build failure and also includes the cherry-picked commit of the below PR:
#5809
Dashboards accessed using the public url use the cached query result mechanism to fetch results after a query job is finished.
When using parameterized queries, the frontend requests the data usually 2 times: one time after changing the parameter, and one time after the job is finished. The second request relies on the caching mechanism to find the cached result of the first request. The second request does not request auto_limit, which causes a lack of splitting and merging of sql statements. Because of that, the two sql queries differ in whitespacing and a trailing semicolon, which causes the query_hashes of both requests to differ.
That results in another job invocation and an empty query result in the second response in the frontend, which causes an endless loading spinner in the frontend and no fetched data.
By splitting the statements each time, you prevent these differences in the 2 sql queries.
Description
How is this tested?
Splitting and merging statements should/can not break anything, otherwise the auto limiting would be buggy. Ran pre-commit to make sure no flake8 errors
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)