Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimization for flushing zero vectors to pinecone #15

Open
wants to merge 5 commits into
base: feature/remote_indexes
Choose a base branch
from

Conversation

swetavooda
Copy link
Contributor

Issue with old approach

  1. Validating large vectors to verify if they are zero-vectors would slow down insertion.
  2. Validating every vector on insert + flushing + build would be redundant and slows down the insertion
  3. The old approach throws an error to the user which blocks the user from inserting the remaining vectors in the buffer if a zero-vector is encountered. Which is a bad experience for the users which requires manual effort to remove the zero-vectors

Solution:

  1. Validate only on flushing + build time.
  2. Do not block user with error. Continue to flush remaining tuples in buffer and display a WARNING.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant