fix "Error: Extra data:" error #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request. Is there any chance you could duplicate this problem in the test suite? There's a test vault you could add a similar kind of password to. It seems like this is probably an encryption padding bug, so just removing a single specific unprintable character won't necessarily fix all cases. |
|
Sure thing. I'll add some test data next week. |
jorgenpt
added a commit
to jorgenpt/1pass
that referenced
this pull request
May 5, 2015
When plaintext is already aligned to a 16 byte boundary, 1Password appends a full block of "0x10." There's an off by one error, where we do not handle that case. This should be a correct fix for georgebrock#5.
This was referenced May 5, 2015
|
I can confirm this issue and its still present after Jorgents fix, however I would use "strip" instead of "replace". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using 1Password 4, it seems that I get this error on some entries:
I tracked it down to there be extra non-printing characters at the end of the decrypted json data. This change fixed it for me.