Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dynamic_core.cc #6168

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Francyrad
Copy link

@Francyrad Francyrad commented Dec 1, 2024

The previous code would halt if no solution was found for the inner core, preventing the simulation from proceeding. This limitation made it impossible to observe the Earth's mantle evolution during cooling when the inner core had not yet formed.

The updated code addresses this issue. Now, if the inner core has not formed, the simulation continues, allowing the core-mantle boundary (CMB) to cool. If the inner core eventually forms during the simulation, its radius will be recorded in the statistics.

Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.

Describe what you did in this PR and why you did it.

Before your first pull request:

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

The previous code would halt if no solution was found for the inner core, preventing the simulation from proceeding. This limitation made it impossible to observe the Earth's mantle evolution during cooling when the inner core had not yet formed.

The updated code addresses this issue. Now, if the inner core has not formed, the simulation continues, allowing the core-mantle boundary (CMB) to cool. If the inner core eventually forms during the simulation, its radius will be recorded in the statistics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant