-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ruff version #503
Update ruff version #503
Conversation
Reviewer's Guide by SourceryThis PR primarily focuses on code organization and cleanup, particularly around import statements and module exports. The changes include explicit imports instead of wildcard imports, alphabetical ordering of all lists, and an update to the ruff linter version. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
instance["params"][param] = ( | ||
float(match.group(1)) * CONVERSION[match.group(2)] | ||
float(match[1]) * CONVERSION[match.group(2)] | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (code-quality): Replace m.group(x) with m[x] for re.Match objects (use-getitem-for-re-match-groups
)
instance["params"][param] = ( | |
float(match.group(1)) * CONVERSION[match.group(2)] | |
float(match[1]) * CONVERSION[match.group(2)] | |
) | |
instance["params"][param] = float(match[1]) * CONVERSION[match[2]] |
Summary by Sourcery
Reorganize import statements across multiple modules for improved code clarity and maintainability. Simplify the 'get_instances' function in the spice_to_yaml module by optimizing list comprehensions and removing redundant code. Update the ruff version in the pre-commit configuration to v0.8.0.
Enhancements:
Build: