Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore empty layers in meshing and use layer resolutions for port-layers #35

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

HelgeGehring
Copy link
Collaborator

@simbilod
Copy link
Collaborator

@mdecea I think you wanted this too

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #35 (257157c) into main (80fed4e) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   41.14%   41.11%   -0.03%     
==========================================
  Files         154      154              
  Lines        9858     9865       +7     
==========================================
  Hits         4056     4056              
- Misses       5802     5809       +7     
Files Changed Coverage Δ
gplugins/gmsh/xyz_mesh.py 27.94% <0.00%> (-3.21%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joamatab joamatab merged commit fe02854 into gdsfactory:main Aug 16, 2023
10 of 12 checks passed
@joamatab
Copy link
Contributor

Thank you Helge!

simbilod pushed a commit to simbilod/gplugins that referenced this pull request Sep 9, 2023
…layers

ignore empty layers in meshing and use layer resolutions for port-layers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants