Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remove entity node #629

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Add remove entity node #629

merged 4 commits into from
Nov 14, 2024

Conversation

Wiktor-99
Copy link
Contributor

🎉 New feature

Summary

Add remove entity node (complementary to create)

Test it

Run gz sim with any entity and call remove launch as follows:

ros2 launch ros_gz_sim gz_remove_model.launch.py world:='world_name' entity_to_remove_name:='entity_name'

Test are also provided.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

ahcorde
ahcorde requested changes Nov 4, 2024
View reviewed changes
ros_gz_sim/CMakeLists.txt Show resolved Hide resolved
@azeey azeey mentioned this pull request Nov 4, 2024
Draft
9 tasks
ahcorde
ahcorde requested changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small nits, otherwise LGTM

ros_gz_sim/CMakeLists.txt Outdated Show resolved Hide resolved
ros_gz_sim/src/remove.cpp Show resolved Hide resolved
@Wiktor-99
Copy link
Contributor Author

Done

@ahcorde ahcorde merged commit 04446e0 into gazebosim:ros2 Nov 14, 2024
4 checks passed
Amronos pushed a commit to Amronos/ros_gz that referenced this pull request Nov 15, 2024
@Wiktor-99 @Amronos
Add remove entity node (gazebosim#629)
9eb7e3e 
Signed-off-by: Wiktor Bajor <[email protected]>
Signed-off-by: Aarav Gupta <[email protected]>
@Amronos Amronos mentioned this pull request Nov 21, 2024
Merged
9 tasks
@ahcorde
Copy link
Collaborator

ahcorde commented Nov 21, 2024

https://github.com/Mergifyio backport jazzy

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 21, 2024 •
edited
Loading

backport jazzy

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 21, 2024
@Wiktor-99 @mergify
Add remove entity node (#629)
733f347 
Signed-off-by: Wiktor Bajor <[email protected]>
(cherry picked from commit 04446e0)
@mergify mergify bot mentioned this pull request Nov 21, 2024
Merged
9 tasks
ahcorde pushed a commit that referenced this pull request Nov 21, 2024
@mergify @Wiktor-99
Add remove entity node (#629) (#647)
c2c015e 
Signed-off-by: Wiktor Bajor <[email protected]>
(cherry picked from commit 04446e0)

Co-authored-by: Wiktor Bajor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@caguero caguero Awaiting requested review from caguero

Assignees
No one assigned
Labels
None yet
Projects
Core development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wiktor-99 @ahcorde @caguero