Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport humble] Fix double wait in ros_gz_bridge (#347) #450

Merged
merged 1 commit into from
Sep 13, 2023
Merged

[backport humble] Fix double wait in ros_gz_bridge (#347) #450

merged 1 commit into from
Sep 13, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Sep 13, 2023

🦟 Bug fix

Backport Fix double wait in ros_gz_bridge (#347)

Summary

Remove gz::transport::waitForShutdown() from ros_gz_bridge and ros_gz_image

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde mentioned this pull request Sep 13, 2023
Merged
8 tasks
@mjcarroll mjcarroll merged commit 151d3d8 into humble Sep 13, 2023
10 checks passed
@mjcarroll mjcarroll deleted the ahcorde/humble/347 branch September 13, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @mjcarroll @ymd-stella