Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wave shaders for vulkan #3

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Update wave shaders for vulkan #3

merged 3 commits into from
Aug 25, 2023

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 14, 2023

🦟 Bug fix

Summary

The waves shaders are updated to work in vulkan. The changes only make the shaders compile and prevent a crash bu that the waves do not render correctly yet in vulkan. I think the shader param system (used by waves) does not work in vulkan.

  • Update (463099d): shaders should be working in vulkan now

Other notes:

  • GUI crashes when run with vulkan. Seems to be Qt + ogre + vulkan interaction issue. So testing is done with vulkan on server side only.
  • During testing, I frequently run into gazebo gui crashes when opening Image Display gui plugin. This may be due to threading / race condition issue.

To test:

Run gazebo as normal to make sure that OpenGL still works:

# enable vulkan on server side only
# note `libvulkan-dev` needs to be installed for gz-rendering to be built with vulkan support
gz sim -v 4 -r harmonic_demo/harmonic.sdf --render-engine-server-api-backend vulkan

The gui is still using OpenGL and the waves should still work.

Open Image Display, hit refresh button to see the waves in the camera sensor view (this should be running on vulkan):

harmonic-vulkan-api

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
@iche033 iche033 requested a review from caguero August 14, 2023 23:44
@iche033
Copy link
Contributor Author

iche033 commented Aug 15, 2023

During testing, I frequently run into gazebo gui crashes when opening Image Display gui plugin.

I think it comes from gz-transport. I ticketed gazebosim/gz-transport#430 with steps to reproduce

Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on Ubuntu!

@iche033 iche033 merged commit 244db6e into main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants