Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz CLI Migration : gz-transport #321

Merged
merged 2 commits into from
Jun 21, 2022
Merged

ign -> gz CLI Migration : gz-transport #321

merged 2 commits into from
Jun 21, 2022

Conversation

methylDragon
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 12, 2022
@methylDragon methylDragon mentioned this pull request Jun 12, 2022
Closed
18 tasks
@methylDragon methylDragon marked this pull request as ready for review June 13, 2022 05:37
@methylDragon methylDragon force-pushed the cli_migration branch 5 times, most recently from 6c919d5 to e0c3d6c Compare June 13, 2022 06:34
@methylDragon
Copy link
Contributor Author

CI failure needs the merge of gz-tools so the gz executable is available

@methylDragon methylDragon added the needs upstream release Blocked by a release of an upstream library label Jun 13, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 13, 2022
@methylDragon
Move CLI files
ce55ff5 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate CLI
160dd89 
Signed-off-by: methylDragon <[email protected]>
@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #321 (8b688e5) into main (f0ebc57) will not change coverage.
The diff coverage is n/a.

❗ Current head 8b688e5 differs from pull request most recent head 160dd89. Consider uploading reports for the commit 160dd89 to get more accurate results

@@           Coverage Diff           @@
##             main     #321   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files          52       52           
  Lines        4850     4850           
=======================================
  Hits         4284     4284           
  Misses        566      566
Impacted Files Coverage Δ
include/gz/transport/ReqHandler.hh 80.58% <ø> (ø)
src/cmd/gz.cc 95.31% <ø> (ø)
src/cmd/service_main.cc 96.00% <ø> (ø)
src/cmd/topic_main.cc 95.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0ebc57...160dd89. Read the comment docs.

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jun 21, 2022
chapulina
chapulina approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNIT_gz_TEST passes on Linux and macOS. Also tested locally.

I'll rebase-merge since this has moved files.

@chapulina chapulina merged commit 24c2445 into main Jun 21, 2022
@chapulina chapulina deleted the cli_migration branch June 21, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina