Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz Macro Migration : gz-transport #319

Merged
merged 5 commits into from
Jun 18, 2022
Merged

Conversation

methylDragon
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 6, 2022
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 7, 2022
@chapulina chapulina self-requested a review June 7, 2022 00:01
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jun 9, 2022
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 minor comments

include/ignition/transport/Helpers.hh Outdated Show resolved Hide resolved
src/cmd/ign.hh Outdated Show resolved Hide resolved
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #319 (70e3436) into main (fbde7d7) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files          52       52           
  Lines        4850     4850           
=======================================
  Hits         4284     4284           
  Misses        566      566           
Impacted Files Coverage Δ
include/gz/transport/Clock.hh 100.00% <ø> (ø)
include/gz/transport/Discovery.hh 85.94% <ø> (ø)
log/include/gz/transport/log/Playback.hh 100.00% <ø> (ø)
src/NetUtils.cc 72.89% <ø> (ø)
src/Node.cc 92.34% <ø> (ø)
src/NodeShared.cc 78.02% <ø> (ø)
src/cmd/ign.cc 95.31% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbde7d7...70e3436. Read the comment docs.

@methylDragon methylDragon merged commit f0ebc57 into main Jun 18, 2022
@methylDragon methylDragon deleted the macro_migration branch June 18, 2022 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants