Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize config macros #90

Merged
merged 10 commits into from
May 24, 2022
Merged

Standardize config macros #90

merged 10 commits into from
May 24, 2022

Conversation

methylDragon
Copy link
Contributor

This PR edits the config macros to look like how all the other config macros will look across the other PRs related to the namespace migration for ign -> gz.

See: gazebo-tooling/release-tools#711

cmake/config.hh.in Outdated Show resolved Hide resolved
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to tick-tock the env var

src/ign.in Show resolved Hide resolved
cmake/config.hh.in Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the standardize_config_macros branch 3 times, most recently from 8bfa8ae to d5ef03a Compare May 24, 2022 00:51
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

src/ign.in Show resolved Hide resolved
@chapulina chapulina enabled auto-merge (squash) May 24, 2022 19:12
@chapulina chapulina merged commit b1e240f into main May 24, 2022
@chapulina chapulina deleted the standardize_config_macros branch May 24, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants