Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend to PYTHONPATH in tests (backport #2673) #2681

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 18, 2024

🦟 Bug fix

Fixes failing python tests

Summary

Preserve the existing PYTHONPATH by prepending instead of replacing. This is needed since we started using a virtual environment in CI.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #2673 done by [Mergify](https://mergify.com).

Preserve the existing PYTHONPATH by prepending
instead of replacing.

Signed-off-by: Steve Peters <[email protected]>
(cherry picked from commit 0d346de)
@mergify mergify bot requested a review from mjcarroll as a code owner November 18, 2024 17:55
@mergify mergify bot mentioned this pull request Nov 18, 2024
8 tasks
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Nov 18, 2024
@arjo129 arjo129 merged commit 1bbb645 into gz-sim8 Nov 19, 2024
10 checks passed
@arjo129 arjo129 deleted the mergify/bp/gz-sim8/pr-2673 branch November 19, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants