Fix crash in OpticalTactilePlugin by checking for valid visualize pointer (backport #2674) #2677
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #2543
Summary
See steps in #2543 to reproduce the crash.
Calling the service to disable the plugin (when it has never been enabled before) will cause a crash because the optical tactile visualization marker pointer is null (not created yet). This PR adds a check to make sure the optical tactile visualization marker pointer is not null before attempting to remove the visualization markers.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.This is an automatic backport of pull request #2674 done by [Mergify](https://mergify.com).