Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in OpticalTactilePlugin by checking for valid visualize pointer (backport #2674) #2677

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 12, 2024

🦟 Bug fix

Fixes #2543

Summary

See steps in #2543 to reproduce the crash.

Calling the service to disable the plugin (when it has never been enabled before) will cause a crash because the optical tactile visualization marker pointer is null (not created yet). This PR adds a check to make sure the optical tactile visualization marker pointer is not null before attempting to remove the visualization markers.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #2674 done by [Mergify](https://mergify.com).

Signed-off-by: Ian Chen <[email protected]>
(cherry picked from commit 57599fb)
@ahcorde ahcorde enabled auto-merge (squash) November 12, 2024 11:34
@ahcorde ahcorde requested a review from iche033 November 12, 2024 16:45
@iche033 iche033 merged commit eea1c9a into gz-sim7 Nov 12, 2024
8 of 11 checks passed
@iche033 iche033 deleted the mergify/bp/gz-sim7/pr-2674 branch November 12, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants