Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore CXX_STANDARD 17 and test gz-cmake PR #1586

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Testing gazebosim/gz-cmake#274.

Summary

Restore CXX_STANDARD export in core library since it uses c++ features in API, and also test a gz-cmake PR using ci_matching_branch/ with gazebo-tooling/gazebodistro@2eb328d and osrf/homebrew-simulation@b1acded

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1586 (fbbe755) into main (a3cbd8c) will decrease coverage by 0.03%.
The diff coverage is 99.31%.

@@            Coverage Diff             @@
##             main    #1586      +/-   ##
==========================================
- Coverage   63.62%   63.59%   -0.04%     
==========================================
  Files         330      330              
  Lines       25787    25925     +138     
==========================================
+ Hits        16408    16487      +79     
- Misses       9379     9438      +59     
Impacted Files Coverage Δ
include/gz/sim/EventManager.hh 79.16% <ø> (ø)
include/gz/sim/Util.hh 100.00% <ø> (ø)
include/gz/sim/components/Factory.hh 97.53% <80.00%> (-1.18%) ⬇️
include/gz/sim/EntityComponentManager.hh 100.00% <100.00%> (ø)
include/gz/sim/Link.hh 100.00% <100.00%> (ø)
include/gz/sim/Model.hh 100.00% <100.00%> (ø)
include/gz/sim/SdfEntityCreator.hh 100.00% <100.00%> (ø)
include/gz/sim/Server.hh 100.00% <100.00%> (ø)
include/gz/sim/ServerConfig.hh 100.00% <100.00%> (ø)
include/gz/sim/SystemLoader.hh 100.00% <100.00%> (ø)
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e314f9...fbbe755. Read the comment docs.

@chapulina chapulina added the 🌱 garden Ignition Garden label Jul 12, 2022
@scpeters scpeters marked this pull request as ready for review July 12, 2022 16:39
@scpeters scpeters requested a review from chapulina as a code owner July 12, 2022 16:39
@scpeters scpeters merged commit 9d24893 into main Jul 12, 2022
@scpeters scpeters deleted the ci_matching_branch/migrate_ign_cmake_files branch July 12, 2022 16:41
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants