Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Macro Migration : gz-sim #1520

Merged
merged 17 commits into from
Jun 18, 2022
Merged

ign -> gz Macro Migration : gz-sim #1520

merged 17 commits into from
Jun 18, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Jun 6, 2022
Closed
@chapulina chapulina added ign to gz Renaming Ignition to Gazebo. 🌱 garden Ignition Garden labels Jun 6, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jun 7, 2022
@chapulina chapulina changed the base branch from main to env_var_migration June 7, 2022 19:19
chapulina
chapulina suggested changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM besides the Fuel directories.

test/integration/log_system.cc Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the macro_migration branch 3 times, most recently from 7ace12d to d877071 Compare June 8, 2022 00:24
Base automatically changed from env_var_migration to main June 9, 2022 02:28
chapulina
chapulina suggested changes Jun 9, 2022
View reviewed changes
src/ign.hh Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the macro_migration branch 2 times, most recently from 5fa3d15 to 95440b2 Compare June 14, 2022 18:27
@methylDragon
Migrate IGN_ASSERT to GZ_ASSERT
5d9be45 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Fold in some unrelated comment changes
84e1a76 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Fix an Gazebo to a Gazebo
e720dd7 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Revert fuel cache paths
ca5c09e 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Tick-tock ignition:type
d2abf82 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Tick-tock ignition-gui
5203bd3 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Tick-tock header functions
316c3e2 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Fix header function tick-tocks
fe9c0ed 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate macros from forward port
d11d4e6 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Hard-tock ignitionGazeboVersion -> gzSimVersion
dd19936 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Hard-tock gazeboVersionHeader -> simVersionHeader
1bac1c1 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon reopened this Jun 18, 2022
@methylDragon methylDragon merged commit a9993ea into main Jun 18, 2022
@methylDragon methylDragon deleted the macro_migration branch June 18, 2022 03:11
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang mabelzhang is a code owner

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina