Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use //sensor/frame_id sdf element #444

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Use //sensor/frame_id sdf element #444

merged 4 commits into from
Jul 9, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jul 3, 2024

🎉 New feature

Related issue: #306
Depends on: gazebosim/sdformat#1454

Summary

The different ways of specifying sensor frame id are being deprecated. This PR makes use of the new //sensor/frame_id sdf element introduced in gazebosim/sdformat#1454. It also deprecates the use of the custom <gz_frame_id> tag. If both tags exist, <frame_id> will override <gz_frame_id>

Test it

All test files have been updated to use <frame_id> instead of <gz_frame_id> and the affected integration tests should pass, e.g. depth, thermal, rgbd camera integration tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Jul 3, 2024
@iche033 iche033 merged commit b91047f into main Jul 9, 2024
8 checks passed
@iche033 iche033 deleted the sensor_frame_id branch July 9, 2024 22:06
@iche033 iche033 mentioned this pull request Jul 9, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants