Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Related issue: #306
Depends on: gazebosim/sdformat#1454
Summary
The different ways of specifying sensor frame id are being deprecated. This PR makes use of the new //sensor/frame_id sdf element introduced in gazebosim/sdformat#1454. It also deprecates the use of the custom
<gz_frame_id>
tag. If both tags exist,<frame_id>
will override<gz_frame_id>
Test it
All test files have been updated to use
<frame_id>
instead of<gz_frame_id>
and the affected integration tests should pass, e.g. depth, thermal, rgbd camera integration tests.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.