Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Header Migration : gz-sensors #221

Merged
merged 4 commits into from
May 14, 2022
Merged

ign -> gz Header Migration : gz-sensors #221

merged 4 commits into from
May 14, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from iche033 as a code owner May 6, 2022 22:01
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 6, 2022
@methylDragon methylDragon mentioned this pull request May 6, 2022
Closed
@methylDragon methylDragon marked this pull request as draft May 6, 2022 22:02
methylDragon added a commit that referenced this pull request May 7, 2022
@methylDragon
Move header files with git mv (#221)
0ca2463 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request May 7, 2022
@methylDragon
Create redirection aliases (#221)
6de2850 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request May 7, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#221)
17c267a 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request May 7, 2022
@methylDragon
Migrate CMake files (#221)
64e27a3 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request May 7, 2022
@methylDragon
Create redirection aliases (#221)
9e1c5db 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request May 7, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#221)
a51fc7d 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request May 7, 2022
@methylDragon
Migrate CMake files (#221)
d55c571 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon marked this pull request as ready for review May 7, 2022 01:39
methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#221)
c4ea4f6 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Migrate CMake files (#221)
b4bdca0 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Create redirection aliases (#221)
1d43036 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#221)
167ad7a 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Migrate CMake files (#221)
3f28f18 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Create redirection aliases (#221)
9561b4a 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#221)
0a55a78 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Migrate CMake files (#221)
b5f4623 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

1 similar comment
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@codecov
Copy link

codecov bot commented May 11, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@29b8a57). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head fc0896c differs from pull request most recent head c2ff16f. Consider uploading reports for the commit c2ff16f to get more accurate results

@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage        ?   80.00%           
=======================================
  Files           ?        1           
  Lines           ?       15           
  Branches        ?        0           
=======================================
  Hits            ?       12           
  Misses          ?        3           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29b8a57...c2ff16f. Read the comment docs.

@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

1 similar comment
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

methylDragon added a commit that referenced this pull request May 11, 2022
@methylDragon
Migrate CMake files (#221)
15e0abd 
Signed-off-by: methylDragon <[email protected]>
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label May 11, 2022
chapulina
chapulina approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither the Jammy rendering failures nor the Windows warnings are introduced by this PR.

@methylDragon methylDragon force-pushed the header_migration branch 6 times, most recently from 440c79b to c18c1b8 Compare May 13, 2022 04:45
methylDragon added a commit that referenced this pull request May 13, 2022
@methylDragon
Migrate CMake files (#221)
6a05406 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate CMake files (#221)
c2ff16f 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon force-pushed the header_migration branch 2 times, most recently from 7758a40 to c2ff16f Compare May 13, 2022 20:36
@methylDragon methylDragon merged commit 75027c2 into main May 14, 2022
@methylDragon methylDragon deleted the header_migration branch May 14, 2022 00:41
methylDragon added a commit that referenced this pull request May 14, 2022
@methylDragon
Move header files with git mv (#221)
d4a7d77 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request May 14, 2022
@methylDragon
Create redirection aliases (#221)
90cd213 
Signed-off-by: methylDragon <[email protected]>
methylDragon added a commit that referenced this pull request May 14, 2022
@methylDragon
Migrate sources in src, test, examples, and include (#221)
bb35692 
Signed-off-by: methylDragon <[email protected]>
@methylDragon methylDragon mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina