Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignition -> Gazebo #674

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Ignition -> Gazebo #674

merged 1 commit into from
Jul 15, 2022

Conversation

jennuine
Copy link
Contributor

🦟 Bug fix

Part of:

Summary

Updated links and naming in README.md

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jenn Nguyen <[email protected]>
@jennuine jennuine added the QA Quality assurance. label Jul 15, 2022
@jennuine jennuine requested a review from chapulina July 15, 2022 20:26
@jennuine jennuine requested a review from iche033 as a code owner July 15, 2022 20:26
@jennuine jennuine self-assigned this Jul 15, 2022
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 15, 2022
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #674 (cff1b8f) into ign-rendering3 (81fb6d4) will not change coverage.
The diff coverage is n/a.

❗ Current head cff1b8f differs from pull request most recent head b6f51ae. Consider uploading reports for the commit b6f51ae to get more accurate results

@@               Coverage Diff               @@
##           ign-rendering3     #674   +/-   ##
===============================================
  Coverage           53.38%   53.38%           
===============================================
  Files                 131      131           
  Lines               12021    12021           
===============================================
  Hits                 6418     6418           
  Misses               5603     5603           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81fb6d4...b6f51ae. Read the comment docs.

@chapulina chapulina merged commit 0d45f75 into ign-rendering3 Jul 15, 2022
@chapulina chapulina deleted the jennuine/readme_updates branch July 15, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel QA Quality assurance.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants