-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable 24.04 CI, require cmake 3.22.1 #1037
Conversation
Part of gazebosim/gz-cmake#350. Signed-off-by: Steve Peters <[email protected]>
* Fix push branch regex to support multi-digit versions. Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
Doxygen check failed on noble:
moving it back to jammy |
Signed-off-by: Steve Peters <[email protected]>
|
while reading the console output, I noticed that we don't have ogre-next installed in Noble CI, so I've tried to enable that in 002d504 |
Signed-off-by: Steve Peters <[email protected]>
bc4dcf7
to
002d504
Compare
I can revert that if we want to address it separately |
Signed-off-by: Ian Chen <[email protected]>
The tests are failing with undefined symbol issue. I've updated to use the |
ogre2 tests should all pass now. There should only be one ogre1 test failing and there's a workaround in #1033 |
I'll look into the ogre-next 2.3.3 issue separately |
Signed-off-by: Steve Peters <[email protected]>
there are some new gcc warnings, and I'm not sure how to fix them; I'll merge after CI finishes if I don't see any suggestions to resolve them |
the compile warnings should be fixed in #1036 |
looks like @j-rivero already reported the issue with the noble's ogre 2.3 debs: https://bugs.launchpad.net/ubuntu/+source/ogre-next/+bug/2063359. So gz-sim / gz-rendering wont work with |
🎉 New feature
Part of gazebosim/gz-cmake#350.
Summary
This adds a GitHub workflow using Noble and increases our minimum required cmake version to 3.22.1 since we are already requiring that in gz-cmake4. I removed one bit of logic for outdated cmake versions in 4925c87.
It also fixes the push branch regex to support multi-digit versions (copied from gazebosim/sdformat#1445) and fixes the CI badges in the README.
Test it
Check CI results
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.