Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz CLI Migration : gz-plugin #88

Merged
merged 3 commits into from
Jun 21, 2022
Merged

ign -> gz CLI Migration : gz-plugin #88

merged 3 commits into from
Jun 21, 2022

Conversation

methylDragon
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 12, 2022
@methylDragon methylDragon mentioned this pull request Jun 12, 2022
Closed
18 tasks
@methylDragon methylDragon marked this pull request as ready for review June 13, 2022 05:37
@methylDragon methylDragon force-pushed the cli_migration branch 3 times, most recently from 1721ae2 to 07a4412 Compare June 13, 2022 06:22
@codecov
Copy link

codecov bot commented Jun 13, 2022 •
edited
Loading

Codecov Report

Merging #88 (545bf8d) into main (dbd0f97) will increase coverage by 0.46%.
The diff coverage is n/a.

❗ Current head 545bf8d differs from pull request most recent head 6be72f6. Consider uploading reports for the commit 6be72f6 to get more accurate results

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   99.35%   99.82%   +0.46%     
==========================================
  Files          17       15       -2     
  Lines         618      560      -58     
==========================================
- Hits          614      559      -55     
+ Misses          4        1       -3
Impacted Files Coverage Δ
loader/src/cmd/gz.cc
loader/src/cmd/plugin_main.cc

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbd0f97...6be72f6. Read the comment docs.

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 13, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jun 15, 2022
@chapulina chapulina changed the base branch from main to macro_migration June 15, 2022 16:54
@chapulina chapulina changed the base branch from macro_migration to main June 15, 2022 16:54
@methylDragon
Move CLI files
74f9ccb 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate ign executable to gz
a50c6c9 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate ignTest to gzTest
6be72f6 
Signed-off-by: methylDragon <[email protected]>
@chapulina
Copy link
Contributor

@osrf-jenkins run tests again please, now UNIT_gz_TEST should be built

chapulina
chapulina approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNIT_gz_Test is passing on Linux and Homebrew!

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jun 21, 2022
@chapulina chapulina merged commit edb3df1 into main Jun 21, 2022
@chapulina chapulina deleted the cli_migration branch June 21, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina