Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Macro Migration : gz-plugin #87

Merged
merged 7 commits into from
Jun 17, 2022
Merged

ign -> gz Macro Migration : gz-plugin #87

merged 7 commits into from
Jun 17, 2022

Conversation

methylDragon
Copy link
Contributor

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 6, 2022
@methylDragon methylDragon mentioned this pull request Jun 6, 2022
Closed
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 7, 2022
@chapulina chapulina self-requested a review June 7, 2022 00:01
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jun 7, 2022
chapulina
chapulina approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI

@chapulina chapulina enabled auto-merge (squash) June 17, 2022 21:56
@codecov
Copy link

codecov bot commented Jun 17, 2022 •
edited
Loading

Codecov Report

Merging #87 (7c7e9ac) into main (7d43bae) will decrease coverage by 0.32%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   99.67%   99.35%   -0.33%     
==========================================
  Files          17       17              
  Lines         616      618       +2     
==========================================
  Hits          614      614              
- Misses          2        4       +2
Impacted Files Coverage Δ
core/include/gz/plugin/Factory.hh 100.00% <ø> (ø)
core/include/gz/plugin/detail/Factory.hh 94.44% <ø> (ø)
loader/src/cmd/ign.cc 88.88% <33.33%> (-7.12%) ⬇️
loader/src/Loader.cc 100.00% <100.00%> (ø)
loader/src/cmd/plugin_main.cc 100.00% <100.00%> (ø)
register/include/gz/plugin/detail/Register.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d43bae...7c7e9ac. Read the comment docs.

@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@chapulina chapulina merged commit dbd0f97 into main Jun 17, 2022
@chapulina chapulina deleted the macro_migration branch June 17, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

@ahcorde ahcorde Awaiting requested review from ahcorde ahcorde is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina