Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bullet-featherstone: Fix convex hull shape's AABB #637

Merged
merged 1 commit into from
May 13, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented May 11, 2024

🦟 Bug fix

Summary

After setting a btConvexHullShape's collision margin, the AABBs need to be explicitly recalculated.

This has performance implications. When AABBs overlap, More computation is done in terms of building islands, solving constraints, etc. Non overlapping objects at rest can also be deactivated. So this fix helps improve performance when many objects are located close to each other.

For reference, the same calls are done in the bullet examples, e.g. here

The difference in broadphase AABBs is visualized below:

bullet_convex_aabb

Left: No recalculation (before the changes)
Right: AABB recalculated

The AABB size difference is roughly [0.1 0.1 0.1]

Note that there is still some obvious padding in the updated broadphase AABB

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 11, 2024
@iche033 iche033 merged commit 0f59151 into gz-physics7 May 13, 2024
10 checks passed
@iche033 iche033 deleted the bullet_convex_aabb branch May 13, 2024 17:42
@iche033 iche033 added the Bullet Bullet engine label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bullet Bullet engine 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants