Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no gravity link support #633

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

AzulRadio
Copy link
Contributor

@AzulRadio AzulRadio commented May 8, 2024

🎉 New feature

Original issue: gazebosim/gz-sim#504

Summary

Add parsing and support for no gravity link when using DartSim engine

For implementation and test details, see gazebosim/gz-sim#2398

Changes in other repo:
gz-physics: #633
sdformat: gazebosim/sdformat#1410

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 8, 2024
@AzulRadio AzulRadio marked this pull request as ready for review May 8, 2024 05:12
dartsim/src/SDFFeatures.cc Outdated Show resolved Hide resolved
dartsim/src/SDFFeatures.cc Outdated Show resolved Hide resolved
Signed-off-by: youhy <[email protected]>
@AzulRadio AzulRadio requested a review from ahcorde May 9, 2024 09:37
@ahcorde ahcorde added the needs upstream release Blocked by a release of an upstream library label May 9, 2024
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iche033
Copy link
Contributor

iche033 commented Jun 6, 2024

@osrf-jenkins run tests please

Signed-off-by: Ian Chen <[email protected]>
@AzulRadio AzulRadio merged commit 78e87e4 into gazebosim:ign-physics5 Jun 7, 2024
9 checks passed
@AzulRadio AzulRadio deleted the azulradio/no_grav branch June 7, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress needs upstream release Blocked by a release of an upstream library
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants