-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no gravity link support #633
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2024
ahcorde
requested changes
May 8, 2024
Signed-off-by: youhy <[email protected]>
AzulRadio
force-pushed
the
azulradio/no_grav
branch
from
May 9, 2024 09:35
fc43250
to
ee80426
Compare
Signed-off-by: youhy <[email protected]>
ahcorde
added
the
needs upstream release
Blocked by a release of an upstream library
label
May 9, 2024
ahcorde
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to wait to merge the PR in sdformat https://github.com/gazebosim/sdformat/blob/sdf14/python/test/pyLink_TEST.py
7 tasks
@osrf-jenkins run tests please |
iche033
reviewed
Jun 6, 2024
Signed-off-by: Ian Chen <[email protected]>
iche033
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Original issue: gazebosim/gz-sim#504
Summary
Add parsing and support for no gravity link when using DartSim engine
For implementation and test details, see gazebosim/gz-sim#2398
Changes in other repo:
gz-physics: #633
sdformat: gazebosim/sdformat#1410
Test it
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.