Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #621 to Garden #629

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Backport #621 to Garden #629

merged 2 commits into from
Apr 22, 2024

Conversation

scpeters
Copy link
Member

Backport #621 to Garden

Disable test failing due to ODE/libccd (#621)

Build Status https://build.osrfoundation.org/job/gz_physics-ci-gz-physics6-homebrew-amd64/40/testReport/

Part of #620.

Original PR description

Disable test failing due to ODE/libccd (#621)

🦟 Bug fix

Part of #620.

Summary

As noted in #620, the JointFeaturesDetachTest/0.JointDetach test has been failing on macOS since ODE 0.16.5 was merged to homebrew-core in Homebrew/homebrew-core#167158. This disables the failing test expectations while we investigate the cause in #620.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Rebase-and-Merge.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 20, 2024
@scpeters
Fix windows compiler warning (#629)
ea84ff7 
Match comment style in harmonic.

Signed-off-by: Steve Peters <[email protected]>
@scpeters
Copy link
Member Author

fixing windows compiler warning in ea84ff7

@scpeters scpeters merged commit d0f3867 into gz-physics6 Apr 22, 2024
9 checks passed
@scpeters scpeters deleted the scpeters/pick_disable_failing_detach_test branch April 22, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

@azeey azeey azeey approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scpeters @azeey @iche033