Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable check in DetachableJointTest.CorrectAttachmentPoints test for dartsim plugin on homebrew #613

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 29, 2024

🦟 Bug fix

Related issue: #612

Summary

Test started failing recently on hombrew likely due to new ODE 0.6.15 bottle. Disabling check until issue is fixed upstream.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.33%. Comparing base (a86da62) to head (ac0fbe6).

Additional details and impacted files
@@             Coverage Diff              @@
##           gz-physics7     #613   +/-   ##
============================================
  Coverage        78.33%   78.33%           
============================================
  Files              140      140           
  Lines             8072     8072           
============================================
  Hits              6323     6323           
  Misses            1749     1749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scpeters scpeters merged commit d616379 into gz-physics7 Mar 29, 2024
11 checks passed
@scpeters scpeters deleted the disable_check_dart_mac branch March 29, 2024 20:32
scpeters added a commit that referenced this pull request Apr 2, 2024
… for dartsim plugin on macOS (#613)"

This reverts commit d616379.

Signed-off-by: Steve Peters <[email protected]>
scpeters added a commit that referenced this pull request Apr 11, 2024
… for dartsim plugin on macOS (#613)" (#615)

This reverts commit d616379.

Signed-off-by: Steve Peters <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants