Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bullet-featherstone] Fix attaching fixed joint #610

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 22, 2024

🦟 Bug fix

Fixes attaching fixed joint between 2 models.

Summary

When 2 models are attached by a fixed joint in bullet-featherstone, their rotations are not maintained (only the translation was set). This PR fixes the issue.

Test it

Before the fix, when you try to create a detachable joint in gz sim (which uses a fixed joint) between two models with rotations, the parent's rotation will be rotated to match the child's, making the models unstable.

I updated the joint_features test to use models with rotations.

To test with gz sim: run the box_attach.sdf world with bullet-featherstone:

gz sim -v 4 box_attach.sdf --physics-engine gz-physics-bullet-featherstone-plugin

Hit play to create the detachable joint and the boxes become unstable:

bullet_box_attach

After the fix, the box should remain stable when the joint is created.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.33%. Comparing base (7d30e47) to head (8476306).

Additional details and impacted files
@@             Coverage Diff              @@
##           gz-physics7     #610   +/-   ##
============================================
  Coverage        78.32%   78.33%           
============================================
  Files              140      140           
  Lines             8069     8072    +3     
============================================
+ Hits              6320     6323    +3     
  Misses            1749     1749           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 merged commit a86da62 into gz-physics7 Mar 23, 2024
11 checks passed
@iche033 iche033 deleted the bullet_attach_joint branch March 23, 2024 00:12
@iche033 iche033 added the Bullet Bullet engine label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bullet Bullet engine 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants