[bullet-featherstone] Fix attaching fixed joint #610
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes attaching fixed joint between 2 models.
Summary
When 2 models are attached by a fixed joint in bullet-featherstone, their rotations are not maintained (only the translation was set). This PR fixes the issue.
Test it
Before the fix, when you try to create a detachable joint in gz sim (which uses a fixed joint) between two models with rotations, the parent's rotation will be rotated to match the child's, making the models unstable.
I updated the
joint_features
test to use models with rotations.To test with gz sim: run the box_attach.sdf world with bullet-featherstone:
Hit play to create the detachable joint and the boxes become unstable:
After the fix, the box should remain stable when the joint is created.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.