Reduce error to debug and add notes #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/downgrade_error
branch
from
a98d215
to
077d46b
Compare
azeey
approved these changes
Nov 28, 2022
Codecov Report
@@ Coverage Diff @@
## gz-physics6 #452 +/- ##
============================================
Coverage 75.79% 75.79%
============================================
Files 140 140
Lines 7056 7056
============================================
Hits 5348 5348
Misses 1708 1708
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
scpeters
approved these changes
Nov 28, 2022
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #450 by reducing the verbosity of the two errors from "error" to "debug".
In reality, these aren't really errors per se, as the dartsim plugin continues to process the SDF and then attaches meshes and heightmaps in a later stage.
The recent addition of gazebosim/gz-sim#1560 allowing SDF to be constructed in a single shot uncovered these unimplemented functions.
The more complete fix is to take advantage of constructing the models in place, which I have opening an issue for at #451.