gz-msgs-extras: Do not call find_package(Python3) if gz-msgs<majVer>_PYTHON_INTERPRETER is defined #466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Do not raise error in cross-compilation context if
gz-msgs<majorVer>__PYTHON_INTERPRETER
is defined.Summary
When
gz-msgs<majorVer>__PYTHON_INTERPRETER
is defined, its value will be used instead ofPython3::Interpreter
. For this reason, it does not make sense to search for Python3 ifgz-msgs<majorVer>__PYTHON_INTERPRETER
is defined. Moving thefind_package
there simplifies the cross-compilation of gz packages, as it remove the need for CMake to find a working Python interpeter.It would be cool (regardless of the value of
gz-msgs<majorVer>__PYTHON_INTERPRETER
) to only search for Python3 if one project actually callsgz_msgs_generate_messages
, and not if a project just call (sometimes transitively)find_package(gz-msgs<majorVer>)
. However, this would be a more complex change, while the change of this PR is simple and self-contained.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.