Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign -> gz Namespace Migration : gz-msgs #252

Merged
merged 30 commits into from
May 28, 2022
Merged

ign -> gz Namespace Migration : gz-msgs #252

merged 30 commits into from
May 28, 2022

Conversation

methylDragon
Copy link
Contributor

See gazebo-tooling/release-tools#711

Note: The include/gz/msgs redirection headers point to ignition and use the ignition namespace, that's why they need the config.hh to support the namespace remaps in downstream packages.

Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 18, 2022
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
include/gz/msgs/actor.pb.h Show resolved Hide resolved
include/ignition/msgs/config.hh Outdated Show resolved Hide resolved
@methylDragon methylDragon force-pushed the namespace_migration branch 6 times, most recently from d675836 to 7955b00 Compare May 20, 2022 07:55
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Migrating ignition.msgs -> gz.msgs leads to a change in index for splitting any input string. This fixes a failing test.

Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we should be able to tick-tock headers and namespaces. The only thing we haven't found a way of tick-tocking is custom message generation. Most Gazebo libraries and external users don't create custom messages though, so I think it's worth at least tick-tocking headers and namespaces.

I tried these small changes on top of your branches:

What do you think?

CMakeLists.txt Show resolved Hide resolved
include/ignition/msgs/Factory.hh Show resolved Hide resolved
@methylDragon
Copy link
Contributor Author

methylDragon commented May 25, 2022

Migration updated accordingly: e99f08a

include/ignition/msgs/SuppressWarning.hh Outdated Show resolved Hide resolved
test/integration/deprecated_TEST.cc Show resolved Hide resolved
CMakeLists.txt Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
src/CMakeLists.txt Show resolved Hide resolved
@chapulina
Copy link
Contributor

Oh yeah, and because so many files are being moved, we'll need a clean commit history to rebase-merge here. 🙃

@methylDragon
Copy link
Contributor Author

methylDragon commented May 25, 2022

Oh yeah, and because so many files are being moved, we'll need a clean commit history to rebase-merge here. upside_down_face

The files being moved here are the redirection headers added in the header migration, do we need to preserve the history for those (there's no history aside from that single commit)?

Signed-off-by: methylDragon <[email protected]>
Signed-off-by: methylDragon <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files being moved here are the redirection headers added in the header migration, do we need to preserve the history for those (there's no history aside from that single commit)?

Ah fair point, we can squash merge this PR then!


LGTM with 🟢 CI

Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #252 (976c405) into main (03a7434) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #252   +/-   ##
=======================================
  Coverage   15.90%   15.90%           
=======================================
  Files         382      382           
  Lines       71409    71409           
=======================================
  Hits        11361    11361           
  Misses      60048    60048           
Impacted Files Coverage Δ
include/ignition/msgs/statistic.pb.cc
include/ignition/msgs/wireless_nodes.pb.cc
include/ignition/msgs/discovery.pb.cc
include/ignition/msgs/request.pb.cc
include/ignition/msgs/projector.pb.cc
include/ignition/msgs/model_configuration.pb.cc
include/ignition/msgs/rest_post.pb.cc
include/ignition/msgs/camera_cmd.pb.cc
include/ignition/msgs/log_playback_control.pb.cc
include/ignition/msgs/physics.pb.cc
... and 563 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03a7434...976c405. Read the comment docs.

@chapulina chapulina merged commit 2770d34 into main May 28, 2022
@chapulina chapulina deleted the namespace_migration branch May 28, 2022 21:06
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants