Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Namespace Migration : gz-math #430

Merged
merged 24 commits into from
May 28, 2022
Merged

ign -> gz Namespace Migration : gz-math #430

merged 24 commits into from
May 28, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon
Update header guards
ab53715 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Namespace migration
9fe86b8 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Add migration line
7ee4943 
Signed-off-by: methylDragon <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 18, 2022
@methylDragon methylDragon mentioned this pull request May 18, 2022
Closed
@methylDragon
Add deprecation test
df186eb 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Include config.hh
e59911c 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Implement deprecation trick
801dc4b 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate symbol test
b421b81 
Signed-off-by: methylDragon <[email protected]>
@chapulina chapulina added ign to gz Renaming Ignition to Gazebo. needs upstream release Blocked by a release of an upstream library labels May 18, 2022
chapulina
chapulina approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 🟢 CI, just minor comments

src/python_pybind11/src/Angle.hh Show resolved Hide resolved
src/python_pybind11/src/AxisAlignedBox.hh Show resolved Hide resolved
src/ruby/ruby.i
@@ -1,4 +1,4 @@
%module "ignition::math"
%module "gz::math"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this has packaging consequences, we may need to update the -release repo after this is merged

test/integration/deprecated_TEST.cc Show resolved Hide resolved
scpeters
scpeters reviewed May 20, 2022
View reviewed changes
include/gz/math/Material.hh Outdated
@@ -40,7 +40,7 @@ namespace gz
/// enum.
///
/// This class will replace the
/// [MaterialDensity class](https://github.com/ignitionrobotics/ign-common/blob/ign-common1/include/gz/common/MaterialDensity.hh)
/// [MaterialDensity class](https://github.com/gazebosim/gz-common/blob/ign-common1/include/gz/common/MaterialDensity.hh)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed this link was previously broken because the include/gz folder doesn't exist on the ign-common1 branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I point it to main or point gz back to ignition?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can point to main

https://github.com/gazebosim/gz-common/blob/main/include/gz/common/MaterialDensity.hh

@scpeters scpeters mentioned this pull request May 20, 2022
Closed
8 tasks
chapulina
chapulina approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just pending 🟢 CI

Changelog.md Outdated Show resolved Hide resolved
@methylDragon
Update github link
b9dff19 
Signed-off-by: methylDragon <[email protected]>
scpeters
scpeters reviewed May 25, 2022
View reviewed changes
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shoudn't change the namespace references in the parts of our migration guide that refers to old versions.

I'm also not sure we should change the changelog to refer to old versions (like Gazebo math 2) when we aren't changing that code at all. Are we allowed to historically refer to old versions as ignition, or does it all have to change to gazebo?

@scpeters
Copy link
Member

I think we shoudn't change the namespace references in the parts of our migration guide that refers to old versions.

I'm also not sure we should change the changelog to refer to old versions (like Gazebo math 2) when we aren't changing that code at all. Are we allowed to historically refer to old versions as ignition, or does it all have to change to gazebo?

having discussed this further offline, I think the changes are fine as is

@codecov
Copy link

codecov bot commented May 28, 2022 •
edited
Loading

Codecov Report

Merging #430 (b9dff19) into main (84e650a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #430   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          49       49           
  Lines        4396     4396           
=======================================
  Hits         4389     4389           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84e650a...b9dff19. Read the comment docs.

@chapulina chapulina merged commit d6284a5 into main May 28, 2022
@chapulina chapulina deleted the namespace_migration branch May 28, 2022 16:32
@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters left review comments

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methylDragon @scpeters @chapulina