Tidy namespaces #590
Merged
Tidy namespaces #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ahcorde
requested changes
Oct 30, 2023
include/gz/gui/Application.hh
Outdated
| Application *App(); | ||
| } | ||
| } | ||
| class ApplicationPrivate; |
There was a problem hiding this comment.
can we include these classes instead of this forward declaration ?
There was a problem hiding this comment.
I believe that at least ApplicationPrivate doesn't have a declaration in the public API, so we wouldn't be able to.
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/tidy_namespaces_gui7
branch
from
8ca21f4
to
b939f2e
Compare
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/tidy_namespaces_gui7
branch
from
b889f9f
to
b81be50
Compare
azeey
approved these changes
Nov 1, 2023
Signed-off-by: Michael Carroll <[email protected]>
ahcorde
approved these changes
Nov 2, 2023
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to nested namespaces, as they are supported now.
Replaces #582
Split into three commits for easy review: