-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update name and logo on UI, examples and API docs #398
Conversation
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #398 +/- ##
=======================================
Coverage 30.03% 30.03%
=======================================
Files 43 43
Lines 1888 1888
=======================================
Hits 567 567
Misses 1321 1321
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, found a couple more docs in case you want to change in this PR:
gz-gui/include/gz/gui/Conversions.hh
Line 99 in 8ac8b41
/// \brief Return the equivalent ignition key event. gz-gui/include/gz/gui/Helpers.hh
Lines 94 to 96 in 8ac8b41
/// ignition QML modules can be imported from. To import an ignition QML /// module, add this path to the QML engine's import path list before /// attempting to load a QML file that imports ignition QML modules. /// \brief Creates an ignition rendering scene and user camera. - I believe we're deprecating this but I've included it here in case:
gz-gui/src/plugins/scene3d/Scene3D.hh
Line 45 in 8ac8b41
/// \brief Creates an ignition rendering scene and user camera.
Signed-off-by: Louise Poubel <[email protected]>
Thanks! Updated in 96db6c5 |
… QML - Adapt the GammaAdjust element from QtGraphicalEffects to work with Metal - Add shaders from Qt - Create a Vulkan supported version of the fragment shader - Generate a shader pack using qsb - Refactor gamma adjustment QML - Move to own QML file and locate with ignition/gui/qml - Move shaders to a private subfolder - Update resources.qrc - Replace import QtGraphicalEffects 1.0 with import "qrc:/qml" Signed-off-by: Rhys Mainwaring <[email protected]> Move header files with git mv (gazebosim#395) Signed-off-by: methylDragon <[email protected]> Create redirection aliases (gazebosim#395) Signed-off-by: methylDragon <[email protected]> Migrate sources in src, test, examples, and include (gazebosim#395) Signed-off-by: methylDragon <[email protected]> Migrate CMake files (gazebosim#395) Signed-off-by: methylDragon <[email protected]> Update name and logo on UI, examples and API docs (gazebosim#398) Signed-off-by: Louise Poubel <[email protected]>
… QML - Adapt the GammaAdjust element from QtGraphicalEffects to work with Metal - Add shaders from Qt - Create a Vulkan supported version of the fragment shader - Generate a shader pack using qsb - Refactor gamma adjustment QML - Move to own QML file and locate with ignition/gui/qml - Move shaders to a private subfolder - Update resources.qrc - Replace import QtGraphicalEffects 1.0 with import "qrc:/qml" Signed-off-by: Rhys Mainwaring <[email protected]> Move header files with git mv (gazebosim#395) Signed-off-by: methylDragon <[email protected]> Create redirection aliases (gazebosim#395) Signed-off-by: methylDragon <[email protected]> Migrate sources in src, test, examples, and include (gazebosim#395) Signed-off-by: methylDragon <[email protected]> Migrate CMake files (gazebosim#395) Signed-off-by: methylDragon <[email protected]> Update name and logo on UI, examples and API docs (gazebosim#398) Signed-off-by: Louise Poubel <[email protected]>
Summary
Checklist
Updated migration guide (as needed)codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸