Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated non-relocatable macro #352

Merged
merged 4 commits into from
Jun 27, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Apr 24, 2023

🦟 Bug fix

Fixes part of gazebosim/gz-sim#626

Summary

As described in gazebosim/gz-sim#626, we are getting rid of non-relocatable macros. On other libraries this macros have been replaced with functions, but in this case the macro seems unused, so we can simply deprecate it and remove it in a future gz-fuel-tools release. If necessary, relocatable functions can be added in the future.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Silvio Traversaro <[email protected]>
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #352 (099fcce) into gz-fuel-tools8 (9036b58) will not change coverage.
The diff coverage is n/a.

❗ Current head 099fcce differs from pull request most recent head b92c90f. Consider uploading reports for the commit b92c90f to get more accurate results

@@               Coverage Diff               @@
##           gz-fuel-tools8     #352   +/-   ##
===============================================
  Coverage           75.30%   75.30%           
===============================================
  Files                  20       20           
  Lines                2911     2911           
===============================================
  Hits                 2192     2192           
  Misses                719      719           

@j-rivero
Copy link
Contributor

j-rivero commented May 8, 2023

good with green CI (some Windows failures in tests are expected).

@j-rivero
Copy link
Contributor

All failing tests are appearing in the -ci-win job. Probably not related to this PR. Thanks @traversaro

@mjcarroll mjcarroll merged commit a0ef972 into gazebosim:gz-fuel-tools8 Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants