Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz CLI Migration : gz-fuel-tools #262

Merged
merged 6 commits into from
Jun 23, 2022
Merged

ign -> gz CLI Migration : gz-fuel-tools #262

merged 6 commits into from
Jun 23, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon mentioned this pull request Jun 12, 2022
Closed
18 tasks
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 12, 2022
@methylDragon methylDragon marked this pull request as ready for review June 13, 2022 05:37
@methylDragon
Copy link
Contributor Author

methylDragon commented Jun 13, 2022 •
edited
Loading

This is just failing because of the fuel tools url changes/staging issues, I think

Also, it needs the merge of gz-tools so the gz executable is available

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 13, 2022
@methylDragon
Move CLI files
a1c2bf9 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Migrate CLI
7f76c95 
Signed-off-by: methylDragon <[email protected]>
@methylDragon
Copy link
Contributor Author

@osrf-jenkins run tests please!

@methylDragon
Copy link
Contributor Author

methylDragon commented Jun 22, 2022 •
edited
Loading

Lint errors :>
a92f061

methylDragon and others added 2 commits June 22, 2022 16:52
@methylDragon
Fix linting error
a92f061 
Signed-off-by: methylDragon <[email protected]>
@chapulina
The config is still installed to
4e4f31e 
Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented Jun 23, 2022 •
edited
Loading

Codecov Report

Merging #262 (afdb1a4) into main (e6fbac2) will not change coverage.
The diff coverage is n/a.

❗ Current head afdb1a4 differs from pull request most recent head 4e4f31e. Consider uploading reports for the commit 4e4f31e to get more accurate results

@@           Coverage Diff           @@
##             main     #262   +/-   ##
=======================================
  Coverage   73.69%   73.69%           
=======================================
  Files          20       20           
  Lines        2863     2863           
=======================================
  Hits         2110     2110           
  Misses        753      753
Impacted Files Coverage Δ
src/gz.cc 41.43% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6fbac2...4e4f31e. Read the comment docs.

chapulina
chapulina approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UNIT_gz_TEST passes on Linux and macOS!

@chapulina chapulina merged commit b00dc96 into main Jun 23, 2022
@chapulina chapulina deleted the cli_migration branch June 23, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@nkoenig nkoenig Awaiting requested review from nkoenig nkoenig is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@methylDragon @chapulina