Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing header guard for Interface.hh #249

Merged
merged 1 commit into from
May 14, 2022

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Noticed it was missing during #248

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina requested a review from nkoenig as a code owner May 3, 2022 18:36
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels May 3, 2022
@methylDragon
Copy link
Contributor

CI error

libcurl: (51) SSL: no alternative certificate subject name matches target host name 'staging-fuel.ignitionrobotics.org'
  [Wrn] [FuelClient.cc:309] Failed to fetch models from server, returning cached models.
  URL: https://staging-fuel.ignitionrobotics.org/
  Version: 1.0
  API key:

@mjcarroll
Copy link
Contributor

CI error

I think this is due to changes in fuel. In the future, it would be nice to decouple a lot of these tests from having a fuel server actually running.

@chapulina chapulina merged commit 5a3630c into ign-fuel-tools4 May 14, 2022
@chapulina chapulina deleted the chapulina/4/guard branch May 14, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants